Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: listener add tls #104

Merged
merged 3 commits into from
Apr 11, 2023
Merged

wip: listener add tls #104

merged 3 commits into from
Apr 11, 2023

Conversation

baerwang
Copy link
Member

#29

@yang20150702
Copy link
Member

We suggest that you can add some examples about tls.

@yang20150702 yang20150702 self-requested a review January 26, 2023 05:50
@baerwang
Copy link
Member Author

我不确认该代码tls写法是否正确，如果正确的话，加密后的conn的boxio如何转换std::io，给 hyper.conn 使用

@yang20150702
Copy link
Member

我不确认该代码tls写法是否正确，如果正确的话，加密后的conn的boxio如何转换std::io，给 hyper.conn 使用

写法没问题。不过，这里没法统一起来，tls的conn需要单独处理。我添加了review comment

@baerwang baerwang force-pushed the listener-tls branch 5 times, most recently from 18ce9d7 to de53665 Compare February 6, 2023 14:03
@yang20150702
Copy link
Member

@baerwang please check failed ci, I will close this pr.

@yang20150702 yang20150702 merged commit 7227060 into apache:main Apr 11, 2023
@yang20150702
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yang20150702 yang20150702 yang20150702 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baerwang @yang20150702