Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sankey): add itemStyle.borderRadius option for sankey series #19763

Merged
merged 1 commit into from
May 9, 2024

Conversation

deftliang
Copy link

@deftliang deftliang commented Mar 27, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add sankey chart itemStyle.borderRadius support.

Fixed issues

fix: #19750

Details

Before: What was the problem?

Sankey chart itemStyle.borderRadius is not support.

After: How does it behave after the fixing?

Support border Radius configuration

image

Document Info

One of the following should be checked.

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Mar 27, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

Copy link

echarts-bot bot commented May 9, 2024

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added the PR: awaiting doc Document changes is required for this PR. label May 9, 2024
@Ovilia Ovilia merged commit 75dd430 into apache:master May 9, 2024
Copy link

echarts-bot bot commented May 9, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.5.1 milestone May 9, 2024
@Ovilia
Copy link
Contributor

Ovilia commented May 9, 2024

Thanks for your contribution. Do you mind making a pull request to the doc at dev branch?

@plainheart plainheart changed the title feat(sankey): Add sankey chart itemStyle.borderRadius support. feat(sankey): add itemStyle.borderRadius for sankey series May 9, 2024
@plainheart plainheart changed the title feat(sankey): add itemStyle.borderRadius for sankey series feat(sankey): add itemStyle.borderRadius option for sankey series May 9, 2024
@deftliang
Copy link
Author

Thanks for your contribution. Do you mind making a pull request to the doc at dev branch?

I'm glad to help! I have created a pull request. apache/echarts-doc#393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] add borderRadius option to sankey
3 participants