Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): hovering legend items should not trigger tooltip #19549

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jan 25, 2024

fix a bug introduced by #18381

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

#18381 brings a bug that hovering the legend will show tooltips.

Fixed issues

Details

Before: What was the problem?

Tooltip shows when hovering the legend.

After: How does it behave after the fixing?

Tooltip not shows when hovering the legend.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jan 25, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Copy link
Contributor

github-actions bot commented Jan 25, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19549@0392fb3

plainheart
plainheart previously approved these changes Jan 29, 2024
@Ovilia Ovilia merged commit 2deb0fd into release Jan 30, 2024
2 checks passed
Copy link

echarts-bot bot commented Jan 30, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the release-dev branch January 30, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants