Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

GIRAPH-1172 Removed dependency com.google.code.findbugs:annotations #61

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

jdasch
Copy link

@jdasch jdasch commented Feb 22, 2018

Replaced com.google.code.findbugs:annotations:2.0.2 with com.github.stephenc.findbugs:findbugs-annotations:1.3.9-1 and com.google.code.findbugs:jsr305:2.0.2.

Had to remove a couple annotations that don't exist in the older version of the drop-in replacement. There is a newer version of com.github.stephenc.findbugs:findbugs-annotations, but it hasn't been uploaded to maven central for some reason. Moved usage of those annotations to the findbugs-exclude.xml file.

@adamkennedy
Copy link

adamkennedy commented Mar 20, 2018

FindBugs is BSD, there's been some threads in other places indicating this is true based on the LICENSE file, but the maven package was built incorrectly.

@jdasch
Copy link
Author

jdasch commented Mar 20, 2018

I did come across this thread [1], which discusses that com.google.code.findbugs:jsr305 is BSD, and documents that the JSR-305's BSD license is included in the findbugs repo [2]. But the license for FindBugs source is LGPL [3].

Unfortunately, Giraph is using com.google.code.findbugs:annotations which includes both JSR-305 and some FindBugs annotations [4], [5] which do have LGPL headers in the source listings.

[1] findbugsproject/findbugs#128
[2] https:/findbugsproject/findbugs/blob/2.0.2/findbugs/licenses/LICENSE-jsr305.txt
[3] https:/findbugsproject/findbugs/blob/2.0.2/findbugs/licenses/LICENSE.txt
[4] https:/findbugsproject/findbugs/blob/2.0.2/findbugs/src/java/edu/umd/cs/findbugs/annotations/SuppressFBWarnings.java
[5] https:/findbugsproject/findbugs/blob/2.0.2/findbugs/src/java/edu/umd/cs/findbugs/annotations/SuppressWarnings.java

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants