[GOBBLIN-1969] Increase Visibility for Flow Compilation Failures #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phet
reviewed
Dec 2, 2023
| @@ -200,6 +200,12 @@ public void configure(Binder binder) { | |||
| ServiceConfigKeys.TOPOLOGYSPEC_FACTORY_KEY, ServiceConfigKeys.DEFAULT_TOPOLOGY_SPEC_FACTORY)); | |||
| } | |||
|
|
|||
| // Initialize flow catalog before DagManager is enabled so templates are loaded when initializing the DagManager | |||
There was a problem hiding this comment.
I'm not too familiar w/ Guice... but are you sure the call to binder.bind is guaranteed to synchronously carryout "initializing the flow catalog" (so that finishes before the later call to binder.bind(DagManager.class))?
There was a problem hiding this comment.
The order does matter here but this is actually the wrong class initialization and won't fix the problem so leaving out of this PR.
...ervice/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerMetrics.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerMetrics.java
Outdated
Show resolved
Hide resolved
added 2 commits
December 1, 2023 16:20
phet
approved these changes
Dec 4, 2023
Comment on lines
+90
to
+91
| flowMetadata.get(TimingEvent.FlowEventConstants.FLOW_GROUP_FIELD), | ||
| flowMetadata.get(TimingEvent.FlowEventConstants.FLOW_NAME_FIELD)); |
There was a problem hiding this comment.
if we do anything other than logging the value, I recommend a default (even when it should always be set). for logging only, it's safe enough to print null, when that's what's actually returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Empty or null dag execution plans created after compiling do not provide sufficient information as to when and why they occur.
Tests
Existing compilation tests work on flow specs manually constructed. Need more insight into why compilation fails on launch to write more useful unit tests.
Commits