Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2140] Remove isMultiActiveSchedulerEnabled flag and its usages #4035

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abhishekmjain
Copy link
Contributor

@abhishekmjain abhishekmjain commented Aug 22, 2024

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Removed isMultiActiveScheduler flag from:
    1. GobblinServiceGuiceModule and FlowLaunchHandler
    2. GobblinServiceManager and set scheduler to active for all hosts
    3. DagActionStoreChangeMonitor and its factories

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    1. Removed the test cases using this flag

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@abhishekmjain abhishekmjain changed the title Remove isMultiActiveSchedulerEnabled flag and its usages [GOBBLIN-2140] Remove isMultiActiveSchedulerEnabled flag and its usages Aug 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.27%. Comparing base (e501b62) to head (adaf0b5).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4035      +/-   ##
============================================
+ Coverage     45.86%   50.27%   +4.41%     
- Complexity     3257     5906    +2649     
============================================
  Files           707     1073     +366     
  Lines         27865    41232   +13367     
  Branches       2796     4628    +1832     
============================================
+ Hits          12779    20728    +7949     
- Misses        14008    18728    +4720     
- Partials       1078     1776     +698     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@phet phet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR may be superseded by #4031

as that's been merged, please rebase and check whether other changes remain here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants