Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2163] Adding Iceberg TableMetadata Validator #4064

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Blazer-007
Copy link
Contributor

@Blazer-007 Blazer-007 commented Oct 3, 2024

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • [✔️] Here are some details about my PR, including screenshots (if applicable):
    • Added a class which will validate whether schema and partition spec between two tables metadata are similar or not and will throw IllegalArgumentException if there is any mismatch
    • This class will be used in IcebergPartitionDatasetFinder to validate whether we want to proceed with copying of partition data files between source and destination iceberg tables or not.

Tests

  • [✔️] My PR adds the following unit tests OR does not need testing for this extremely good reason:
    • IcebergTableMetadataValidatorTest

Commits

  • [✔️] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@Will-Lo
Copy link
Contributor

Will-Lo commented Oct 3, 2024

Will the integration with IcebergPartitionDatasetFinder be in a separate PR?

@Blazer-007
Copy link
Contributor Author

Will the integration with IcebergPartitionDatasetFinder be in a separate PR?

In this PR only after PR #4058 is merged first.

Copy link

@jainbhupendra24 jainbhupendra24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Looks good with small suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants