Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Define Gobblin-on-TemporalWorkforcePlan and dynamic ScalingDirectives with parser #4068

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

phet
Copy link
Contributor

@phet phet commented Oct 18, 2024

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Forthcoming...

Suggested sequence: begin with ScalingDirective, then WorkforcePlan (and WorkforcePlanTest), and next ScalingDirectiveParser (with ScalingDirectiveParserTest).

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 79.49791% with 49 lines in your changes missing coverage. Please review.

Project coverage is 47.41%. Comparing base (45ad13e) to head (a974557).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...pache/gobblin/temporal/dynamic/ProfileOverlay.java 49.09% 22 Missing and 6 partials ⚠️
...he/gobblin/temporal/dynamic/WorkforceProfiles.java 66.66% 4 Missing and 2 partials ⚠️
...apache/gobblin/temporal/dynamic/WorkforcePlan.java 92.72% 4 Missing ⚠️
...he/gobblin/temporal/dynamic/WorkforceStaffing.java 90.90% 1 Missing and 2 partials ⚠️
...bblin/temporal/dynamic/ScalingDirectiveParser.java 95.45% 2 Missing ⚠️
...pache/gobblin/temporal/dynamic/StaffingDeltas.java 71.42% 2 Missing ⚠️
...emporal/cluster/GobblinTemporalClusterManager.java 0.00% 1 Missing ⚠️
...he/gobblin/temporal/dynamic/ProfileDerivation.java 91.66% 0 Missing and 1 partial ⚠️
...che/gobblin/temporal/dynamic/ScalingDirective.java 90.90% 0 Missing and 1 partial ⚠️
...apache/gobblin/temporal/dynamic/WorkerProfile.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4068      +/-   ##
============================================
+ Coverage     45.12%   47.41%   +2.29%     
- Complexity     3199     8223    +5024     
============================================
  Files           705     1567     +862     
  Lines         26949    62111   +35162     
  Branches       2680     7053    +4373     
============================================
+ Hits          12160    29451   +17291     
- Misses        13781    29967   +16186     
- Partials       1008     2693    +1685     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants