You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Flow: We have implemented metrics collection in ABFS flow. We have created a custom AbfsBackoffMetrics and AbfsReadFooterMetrics class which stores all the metrics on the file system level. Our objective is to move away from the custom class implementation and use IOStatisticsStore to store the metrics which is present in hadoop-common.
Changes Made: This PR contains the changes related to storing metrics related to above mentioned classes in IOStatisticStore which is present in hadoop-common.
hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚
shadedclient
35m 59s
patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚
unit
2m 42s
hadoop-azure in the patch passed.
+1 💚
asflicense
0m 38s
The patch does not generate ASF License warnings.
136m 25s
Reason
Tests
SpotBugs
module:hadoop-tools/hadoop-azure
org.apache.hadoop.fs.azurebfs.constants.MetricsConstants.RETRY_LIST is a mutable collection At MetricsConstants.java: At MetricsConstants.java:[line 28]
hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚
shadedclient
36m 22s
patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚
unit
2m 42s
hadoop-azure in the patch passed.
+1 💚
asflicense
0m 37s
The patch does not generate ASF License warnings.
146m 2s
Reason
Tests
SpotBugs
module:hadoop-tools/hadoop-azure
org.apache.hadoop.fs.azurebfs.constants.MetricsConstants.RETRY_LIST is a mutable collection At MetricsConstants.java: At MetricsConstants.java:[line 28]
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: https://issues.apache.org/jira/browse/HADOOP-19311
Current Flow: We have implemented metrics collection in ABFS flow. We have created a custom AbfsBackoffMetrics and AbfsReadFooterMetrics class which stores all the metrics on the file system level. Our objective is to move away from the custom class implementation and use IOStatisticsStore to store the metrics which is present in hadoop-common.
Changes Made: This PR contains the changes related to storing metrics related to above mentioned classes in IOStatisticStore which is present in hadoop-common.