fix test compile issues

hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestFileSystemViewCommand.java

@@ -116,7 +116,7 @@ private void createNonpartitionedTable() throws IOException {
  // Reload meta client and create fsView
  metaClient = HoodieTableMetaClient.reload(metaClient);
 
- nonpartitionedFsView = new HoodieTableFileSystemView(metaClient, metaClient.getActiveTimeline(), true);
+ nonpartitionedFsView = HoodieTableFileSystemView.fileListingBasedFileSystemView(context(), metaClient, metaClient.getActiveTimeline(), true);
  }
 
  private void createPartitionedTable() throws IOException {
@@ -159,7 +159,7 @@ private void createPartitionedTable() throws IOException {
  // Reload meta client and create fsView
  metaClient = HoodieTableMetaClient.reload(metaClient);
 
- partitionedFsView = new HoodieTableFileSystemView(metaClient, metaClient.getActiveTimeline(), true);
+ partitionedFsView = HoodieTableFileSystemView.fileListingBasedFileSystemView(context(), metaClient, metaClient.getActiveTimeline(), true);
  }
 
  /**

hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java

@@ -781,7 +781,7 @@ public void testMetadataTableDeletePartition(HoodieTableType tableType) throws E
 
  final Map<String, MetadataPartitionType> metadataEnabledPartitionTypes = new HashMap<>();
  metadataWriter.getEnabledPartitionTypes().forEach(e -> metadataEnabledPartitionTypes.put(e.getPartitionPath(), e));
- HoodieTableFileSystemView fsView = new HoodieTableFileSystemView(metadataMetaClient, metadataMetaClient.getActiveTimeline());
+ HoodieTableFileSystemView fsView = HoodieTableFileSystemView.fileListingBasedFileSystemView(engineContext, metadataMetaClient, metadataMetaClient.getActiveTimeline());
  metadataTablePartitions.forEach(partition -> {
  List<FileSlice> latestSlices = fsView.getLatestFileSlices(partition).collect(Collectors.toList());
  if (COLUMN_STATS.getPartitionPath().equals(partition)) {

hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/TestHoodieMergeHandleWithSparkMerger.java

@@ -197,7 +197,7 @@ public CustomWriteConfig buildCustomWriteConfig(Schema avroSchema) {
  }
 
  public HoodieTableFileSystemView getFileSystemView() {
- return new HoodieTableFileSystemView(metaClient, metaClient.getActiveTimeline());
+ return HoodieTableFileSystemView.fileListingBasedFileSystemView(context(), metaClient, metaClient.getActiveTimeline());
  }
 
  public List<FileSlice> getLatestFileSlices(String partitionPath) {

hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java

@@ -59,7 +59,6 @@
 import org.apache.hudi.common.table.view.FileSystemViewStorageConfig;
 import org.apache.hudi.common.table.view.FileSystemViewStorageType;
 import org.apache.hudi.common.table.view.HoodieTableFileSystemView;
-import org.apache.hudi.common.table.view.SpillableMapBasedFileSystemView;
 import org.apache.hudi.common.util.CleanerUtils;
 import org.apache.hudi.common.util.ConfigUtils;
 import org.apache.hudi.common.util.FileFormatUtils;
@@ -1650,10 +1649,10 @@ public HoodieMetadataValidationContext(
  FileSystemViewStorageConfig viewConf = FileSystemViewStorageConfig.newBuilder().fromProperties(props).build();
  ValidationUtils.checkArgument(viewConf.getStorageType().name().equals(viewStorageType), "View storage type not reflected");
  HoodieCommonConfig commonConfig = HoodieCommonConfig.newBuilder().fromProperties(props).build();
- this.fileSystemView = getFileSystemView(engineContext,
- metaClient, metadataConfig, viewConf, commonConfig);
  this.tableMetadata = HoodieTableMetadata.create(
  engineContext, metaClient.getStorage(), metadataConfig, metaClient.getBasePath().toString());
+ this.fileSystemView = getFileSystemView(engineContext,
+ metaClient, metadataConfig, viewConf, commonConfig);
  if (metaClient.getCommitsTimeline().filterCompletedInstants().countInstants() > 0) {
  this.allColumnNameList = getAllColumnNames();
  }
@@ -1665,18 +1664,17 @@ public HoodieMetadataValidationContext(
  private HoodieTableFileSystemView getFileSystemView(HoodieEngineContext context,
  HoodieTableMetaClient metaClient, HoodieMetadataConfig metadataConfig,
  FileSystemViewStorageConfig viewConf, HoodieCommonConfig commonConfig) {
- HoodieTimeline timeline = metaClient.getActiveTimeline().filterCompletedAndCompactionInstants();
  switch (viewConf.getStorageType()) {
  case SPILLABLE_DISK:
  LOG.debug("Creating Spillable Disk based Table View");
- return new SpillableMapBasedFileSystemView(metaClient, timeline, viewConf, commonConfig);
+ break;
  case MEMORY:
  LOG.debug("Creating in-memory based Table View");
- return FileSystemViewManager.createInMemoryFileSystemView(context,
- metaClient, metadataConfig);
+ break;
  default:
  throw new HoodieException("Unsupported storage type " + viewConf.getStorageType() + ", used with HoodieMetadataTableValidator");
  }
+ return (HoodieTableFileSystemView) FileSystemViewManager.createViewManager(context, metadataConfig, viewConf, commonConfig, unused -> tableMetadata).getFileSystemView(metaClient);
  }
 
  public HoodieTableMetaClient getMetaClient() {

hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieMetadataTableValidator.java

@@ -451,7 +451,7 @@ public void testAdditionalFilesinMetadata(Integer lastNFileSlices) throws IOExce
  assertFalse(validator.hasValidationFailure());
 
  // let's delete one of the log files from 1st commit and so FS based listing and MDT based listing diverges.
- HoodieTableFileSystemView fsView = new HoodieTableFileSystemView(metaClient, metaClient.getActiveTimeline().filterCompletedAndCompactionInstants(), false);
+ HoodieTableFileSystemView fsView = HoodieTableFileSystemView.fileListingBasedFileSystemView(context, metaClient, metaClient.getActiveTimeline().filterCompletedAndCompactionInstants(), false);
  HoodieFileGroup fileGroup = fsView.getAllFileGroups(StringUtils.EMPTY_STRING).collect(Collectors.toList()).get(0);
  List<FileSlice> allFileSlices = fileGroup.getAllFileSlices().collect(Collectors.toList());
  FileSlice earliestFileSlice = allFileSlices.get(allFileSlices.size() - 1);