[HUDI-7104] Fixing cleaner savepoint interplay to fix edge case with incremental cleaning #10651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
changed the title
nsivabalan
force-pushed
the
savepointCleanerFix
branch
2 times, most recently
from
d13ebd4
to
a62585a
Compare
nsivabalan
force-pushed
the
savepointCleanerFix
branch
from
a62585a
to
9ce5d96
Compare
|
codope
reviewed
Feb 14, 2024
...client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/TestCleanPlanner.java
Show resolved
Hide resolved
|
@hudi-bot run azure |
codope
approved these changes
Feb 15, 2024
yihua
pushed a commit
that referenced
this pull request
Feb 27, 2024
…incremental cleaning (#10651) * Fixing incremental cleaning with savepoint * Addressing feedback
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
There are chances that incremental cleaner might miss to clean up some partitions which was part of previously savepointed commit. This patch fixes the gap.
Impact
Incremental cleaner will not miss to clean up older partitions which was touched by a recently removed savepoint but is not updated with regular writes.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist