Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade docusaurus to latest version #11798

Merged

Conversation

pintusoliya
Copy link

Change Logs

Describe context and summary for this change. Highlight if any code was copied.

Impact

Describe any public API or user-facing feature change or any performance impact.

Risk level (write none, low medium or high below)

If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added docs size:XL PR with lines of changes > 1000 labels Aug 20, 2024
@bhasudha bhasudha self-requested a review August 21, 2024 21:38
@bhasudha
Copy link
Contributor

I am looking into this PR.

@pintusoliya pintusoliya changed the title ENG-10966: upgrade docusaurus to latest Upgrade docusaurus to latest version Aug 23, 2024
@bhasudha bhasudha force-pushed the ENG-10966-upgrade-docusaurus-to-latest branch from f16f9fb to 7e8f5e3 Compare August 27, 2024 21:45
Copy link
Contributor

@bhasudha bhasudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Have minor follow ups when some config tables are rendered with a horizontal rule instead of being contained in the given page. Please fix that in a following PR.

@bhasudha
Copy link
Contributor

Tested locally.

image
image
image
image

@bhasudha bhasudha merged commit 19fa8bf into apache:asf-site Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs size:XL PR with lines of changes > 1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants