[HUDI-8382] Improve MOR-Snapshot-Query performance for COW like table #12112
+118
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this change related: #12080 ? |
…read-optimized query 1. regard mor snapshot query with all base-file-only table as mor read-optimized query Signed-off-by: TheR1sing3un <[email protected]>
TheR1sing3un
force-pushed
the
feat_optimize_mor_read_with_empty_log
branch
from
be6673e
to
083aff2
Compare
#12080 is optimizing filter pushdown for HoodieBaseRelation by reducing unnecessary columns. |
github-actions
bot
added
size:M
1. optimize TestDataSkippingWithMORColstats Signed-off-by: TheR1sing3un <[email protected]>
1. fix TestNestedSchemaPruningOptimization Signed-off-by: TheR1sing3un <[email protected]>
1. fix TestSparkSqlWithCustomKeyGenerator, need unified time conversion for mor and cow in the future to solve the root problem Signed-off-by: TheR1sing3un <[email protected]>
danny0405
reviewed
Oct 21, 2024
| @@ -220,6 +220,15 @@ object DataSourceReadOptions { | |||
|
|
|||
| val INCREMENTAL_READ_HANDLE_HOLLOW_COMMIT: ConfigProperty[String] = HoodieCommonConfig.INCREMENTAL_READ_HANDLE_HOLLOW_COMMIT | |||
|
|
|||
| val ENABLE_OPTIMIZED_READ_FOR_MOR_WITH_ALL_BASE_FILE_ONLY_SLICE: ConfigProperty[Boolean] = ConfigProperty | |||
There was a problem hiding this comment.
Isn't that just a read optimized query?
|
@hudi-bot run azure |
|
We have this all optimized with the new filegroup reader already so I'm not sure how much longer the relation implementations will be around anyways |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, a MOR table's latest (or view at time-travel specified instant) file-slices all have only base-file but empty log-files. When performs Snapshot-Query for these tables, we can regard it as MOR-ReadOptimized-Query and provide a HadoopFsRelation to Spark.
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
none
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
low
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist