[HUDI-8386] Fix update for secondary index and corresponding validation in metadata table validator #12119
+38
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on in metadata table validator
codope
requested changes
Oct 17, 2024
Comment on lines
+285
to
+288
| Set<String> recKeys = validator.getFSSecondaryKeyToRecordKeys(new HoodieSparkEngineContext(jsc, sqlContext), basePath, | ||
| metaClient.getActiveTimeline().lastInstant().get().getTimestamp(), "not_record_key_col", Collections.singletonList(secKey)) | ||
| .get(secKey); | ||
| assertEquals(Collections.singletonList(recKey), recKeys); | ||
| assertEquals(Collections.singleton(recKey), recKeys); |
There was a problem hiding this comment.
Yes this is intended
4 tasks
|
There is an e2e test in TestHoodieMetadataTableValidator which is reproducing the failure. Also fixed TestSecondaryIndexPruning. The tests were checking an older state of the table so were passing without the fix. After the update fix, had to fix the test to check the latest state of the table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
The Jira adds update validation for secondary index in metadata table validator. It also makes a fix in update logic and checks for secondary key instead of record key. The earlier logic was leading to some records getting skipped.
Impact
NA
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist