feat(polar) about ISSUE 11452

[foolzhang]

No description provided.

[pissang]

fill and stroke can be set to 'none' if don't want to display it

[pissang]

I think there is no need to set opacity to 0 if fill and stroke are both set to 'none'

[foolzhang]

fill : transparent , opacity: 0 , tooltip can be show if set, i just feel it better.

Is that right？ @Ovilia

[pissang]

I'm not sure if it's a good user experience if cursor becomes to poiner and tooltips shows on a blank area. Perhaps users will think is it a bug that there should be something under the mouse but instead it's blank ?

[foolzhang]

ACK, i commit again

[pissang]

And silent property of the el should be set to true in case it displays again with emphasis style when user is hovering on the area.

[Ovilia]

LGTM accept for what @pissang commented.

[Ovilia]

I've tested test/polar-rounded.html and it looks good.

[pissang]

silent property of the el should be set to true in case it displays again with emphasis style when user is hovering on the area.

Sorry, I was wrong about this. silent property is not needed.

But the style of still needs to be eliminated. If I modify the test case and added emphasis style. 

series: [{
    type: 'bar',
    data: [0],
    coordinateSystem: 'polar',
    name: 'A',
    roundCap: true,
    color: 'rgba(200, 0, 0, 0.5)',
    itemStyle: {
        borderColor: 'red',
        borderWidth: 1
    },
    emphasis: {
        itemStyle: {
            borderColor: 'blue',
            color: 'red',
            opacity: 1
        }
    }
}]

The circle will appear when hovering on the legend.

I think we should also set fill and stroke to 'none' of hoverStyle in the code https:/apache/incubator-echarts/blob/master/src/chart/bar/BarView.js#L419

[foolzhang]

sorry about not consider emphasis and last week I'm confused by what you say about "silent". lastweek i have tryed this

    if(layout.startAngle != layout.endAngle){
        graphic.setHoverStyle(el, hoverStyle);    
    }

it seems ok

[foolzhang]

is any one here?

[pissang]

Hi @foolzhang Sorry for missing this.

Just ignore the silent suggestion. I've made a mistake. It is for disabling the interaction ability of element.

About

 if(layout.startAngle != layout.endAngle){
        graphic.setHoverStyle(el, hoverStyle);    
}

It will cause the hoverStyle not change when the data is changed from a none zero value to zero.

We should always update all to avoid the status leaking from previous update.

if(layout.startAngle === layout.endAngle) {
  hoverStyle.fill = hoverStyle.stroke = 'none';
}
graphic.setHoverStyle(el, hoverStyle)

[foolzhang]

We should always update all to avoid the status leaking from previous update.

reasonable

[pissang]

I found an issue after merged this pull request.

layout.startAngle === layout.endAngle

This is only available for the bar on polar. But there is no validation here and it brokes the bar on normal cartesian coordinate system.

I will make another pull request to fix this issue.