fix(legend): legend of pie/funnel/radar can pick from visualMap encoded color #11737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pissang
changed the title
pissang
changed the title
100pah
previously approved these changes
Nov 30, 2019
| return; | ||
| } | ||
|
|
||
| var color = data.getItemVisual(idx, 'color'); | ||
| var borderColor = data.getItemVisual(idx, 'borderColor'); | ||
| var idx = provider.indexOfName(name); |
There was a problem hiding this comment.
provider.indexOfName seems to have covered the functionality of provider.containName.
Why we need provider.containName and do the O(n) search twice?
test/legend-visualMapColor.html
Outdated
| "01", | ||
| "高档", | ||
| 61278, | ||
| "61278.00" |
There was a problem hiding this comment.
Do we need to obfuscate the data in case some unexpected legal issue?
There was a problem hiding this comment.
I think it should be
| } | ||
| } | ||
| ] | ||
| }; |
There was a problem hiding this comment.
Do we need to add (or already have?) a test case like #2372 described (I know it is correct both before and after this change).
Like:
option = {
legend: {
},
series: {
type: 'pie',
itemStyle: {
color: function (params) {
var colorList = ['#ff3322', '#232211', '#aabbcc'];
return colorList[params.dataIndex];
}
},
data: [
{name: 'a', value: 1222},
{name: 'b', value: 2333},
{name: 'c', value: 3444},
]
}
};
100pah
approved these changes
Dec 1, 2019
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More technique discussion can be seen in #10766 (review)