fix: enable dispatchAction highlight downplay for treemap. fix #9816.
#12050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
pissang
approved these changes
Jan 15, 2020
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
fix: enable
dispatchActionhighlight downplay for treemap.Fixed issues
fix #9816.
Details
Before: What was the problem?
Can not
dispatchActionhighlight downplay for treemap.After: How is it fixed in this PR?
Enabled.
Related test cases or examples to use the new APIs
test/treemap-disk2.htmlOthers
Remain issue
Whether highlight/downplay will effect all the subtree or only the hovered node?
There are both scenarios, depending on the styles the treemap used. For example,
a treemap uses border to distinguish the highlighted subtree, we should only
highlight the target node rather than the entire subtree. Otherwise the all of the
border inner the subtree will be highlighted unexpectedly. If a treemap uses area
color to distinguish the highlighted subtree, the entire subtree needed to be
highlighted.
But I only support "highlight single node" here. Because based on the current
mechanism, implement "highlight entire subtree" need some more code, a little
like
focusNodeAdjacencyingraph series, and event more complicated becausethe zrender elements in treemap are nested so we need to consider a mouse over
listener should/should not listen to its descendent.