[incubator-kie-issues-1484] Create endpoints for user task #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguardian
force-pushed
the
incubator-kie-issues-1484
branch
from
b1e04c6
to
e3913df
Compare
elguardian
force-pushed
the
incubator-kie-issues-1484
branch
from
d496dbe
to
9210216
Compare
elguardian
force-pushed
the
incubator-kie-issues-1484
branch
2 times, most recently
from
66edc38
to
f714891
Compare
martinweiler
reviewed
Oct 4, 2024
| public static final String RELEASE = "release"; | ||
| public static final String COMPLETE = "complete"; | ||
| public static final String SKIP = "skip"; | ||
| public static final String FAIL = "fail"; |
There was a problem hiding this comment.
Shouldn't the custom lifecycle listener provide the following:
- New
startstate - State
completeonly supported fromstart
There was a problem hiding this comment.
added the intermediate start state
martinweiler
reviewed
Oct 4, 2024
| import jakarta.inject.Singleton; | ||
|
|
||
| @Singleton | ||
| public class CustomUserTaskLifeCycle implements UserTaskLifeCycle { |
There was a problem hiding this comment.
Changes to the custom classes require the examples README file to be updated. The current content is outdated:
org.acme.travels.config.CustomWorkItemHandlerConfig - responsible for registering work item handler to deal with user tasks
org.acme.travels.usertasks.CustomHumanTaskLifeCycle - defines actual the life cycle for user tasks
org.acme.travels.usertasks.Start - new life cycle phase
org.acme.travels.usertasks.CompleteStartedOnly - extended Complete life cycle phase to allow only started tasks and reuse all other logic
There was a problem hiding this comment.
added the intermediate start state
elguardian
force-pushed
the
incubator-kie-issues-1484
branch
from
f714891
to
2795c6a
Compare
martinweiler
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
LGTM @elguardian
I have created apache/incubator-kie-issues#1515 to check the custom lifecycle example as follow-up task.
rgdoliveira
pushed a commit
to rgdoliveira/kogito-examples
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1484
depends on apache/incubator-kie-kogito-runtimes#3673