business-calendar #3686

Abhitocode · 2024-10-01T13:16:39Z

No description provided.

kie-ci3 · 2024-10-01T15:50:43Z

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3686 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https:/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3686/1/display/redirect

Test results:

PASSED: 3327
FAILED: 9

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testEventSubprocessTimerCycle

A process instance can only be started once

org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventDateISO

[Process instance is not active.]
Expecting value to be true but was false

org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerCycleWithErrorWithPersistence

[Process instance is not active.]
Expecting value to be true but was false

org.jbpm.bpmn2.StartEventTest.testMultipleEventBasedStartEventsTimerDifferentPaths

java.lang.IllegalArgumentException
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:623)
at org.kie.kogito.services.jobs.impl.InMemoryJobService.scheduleProcessJob(InMemoryJobService.java:86)
at org.jbpm.process.instance.ProcessRuntimeImpl.initStartTimers(ProcessRuntimeImpl.java:127)
at org.jbpm.process.instance.ProcessRuntimeImpl.(ProcessRuntimeImpl.java:112)
at org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl.newProcessRuntime(ProcessRuntimeFactoryServiceImpl.java:38)
at org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl.newProcessRuntime(ProcessRuntimeFactoryServiceImpl.java:25)
at org.drools.kiesession.session.ProcessRuntimeFactory.newProcessRuntime(ProcessRuntimeFactory.java:43)
at org.drools.kiesession.session.StatefulKnowledgeSessionImpl.createProcessRuntime(StatefulKnowledgeSessionImpl.java:410)
at org.drools.kiesession.session.StatefulKnowledgeSessionImpl.getProcessRuntime(StatefulKnowledgeSessionImpl.java:421)
at org.jbpm.process.instance.InternalProcessRuntime.asKogitoProcessRuntime(InternalProcessRuntime.java:55)
at org.jbpm.bpmn2.JbpmBpmn2TestCase.createKogitoProcessRuntime(JbpmBpmn2TestCase.java:118)
at org.jbpm.bpmn2.StartEventTest.testMultipleEventBasedStartEventsTimerDifferentPaths(StartEventTest.java:397)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

org.jbpm.bpmn2.StartEventTest.testMultipleStartEventsStartOnTimer

java.lang.IllegalArgumentException
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:623)
at org.kie.kogito.services.jobs.impl.InMemoryJobService.scheduleProcessJob(InMemoryJobService.java:86)
at org.jbpm.process.instance.ProcessRuntimeImpl.initStartTimers(ProcessRuntimeImpl.java:127)
at org.jbpm.process.instance.ProcessRuntimeImpl.(ProcessRuntimeImpl.java:112)
at org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl.newProcessRuntime(ProcessRuntimeFactoryServiceImpl.java:38)
at org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl.newProcessRuntime(ProcessRuntimeFactoryServiceImpl.java:25)
at org.drools.kiesession.session.ProcessRuntimeFactory.newProcessRuntime(ProcessRuntimeFactory.java:43)
at org.drools.kiesession.session.StatefulKnowledgeSessionImpl.createProcessRuntime(StatefulKnowledgeSessionImpl.java:410)
at org.drools.kiesession.session.StatefulKnowledgeSessionImpl.getProcessRuntime(StatefulKnowledgeSessionImpl.java:421)
at org.jbpm.process.instance.InternalProcessRuntime.asKogitoProcessRuntime(InternalProcessRuntime.java:55)
at org.jbpm.bpmn2.JbpmBpmn2TestCase.createKogitoProcessRuntime(JbpmBpmn2TestCase.java:118)
at org.jbpm.bpmn2.StartEventTest.testMultipleStartEventsStartOnTimer(StartEventTest.java:309)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

org.jbpm.bpmn2.StartEventTest.testMultipleEventBasedStartEventsSignalStart

java.lang.IllegalArgumentException
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:623)
at org.kie.kogito.services.jobs.impl.InMemoryJobService.scheduleProcessJob(InMemoryJobService.java:86)
at org.jbpm.process.instance.ProcessRuntimeImpl.initStartTimers(ProcessRuntimeImpl.java:127)
at org.jbpm.process.instance.ProcessRuntimeImpl.(ProcessRuntimeImpl.java:112)
at org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl.newProcessRuntime(ProcessRuntimeFactoryServiceImpl.java:38)
at org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl.newProcessRuntime(ProcessRuntimeFactoryServiceImpl.java:25)
at org.drools.kiesession.session.ProcessRuntimeFactory.newProcessRuntime(ProcessRuntimeFactory.java:43)
at org.drools.kiesession.session.StatefulKnowledgeSessionImpl.createProcessRuntime(StatefulKnowledgeSessionImpl.java:410)
at org.drools.kiesession.session.StatefulKnowledgeSessionImpl.getProcessRuntime(StatefulKnowledgeSessionImpl.java:421)
at org.jbpm.process.instance.InternalProcessRuntime.asKogitoProcessRuntime(InternalProcessRuntime.java:55)
at org.jbpm.bpmn2.JbpmBpmn2TestCase.createKogitoProcessRuntime(JbpmBpmn2TestCase.java:118)
at org.jbpm.bpmn2.StartEventTest.testMultipleEventBasedStartEventsSignalStart(StartEventTest.java:331)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

org.jbpm.bpmn2.StartEventTest.testMultipleEventBasedStartEventsDifferentPaths

java.lang.IllegalArgumentException
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:623)
at org.kie.kogito.services.jobs.impl.InMemoryJobService.scheduleProcessJob(InMemoryJobService.java:86)
at org.jbpm.process.instance.ProcessRuntimeImpl.initStartTimers(ProcessRuntimeImpl.java:127)
at org.jbpm.process.instance.ProcessRuntimeImpl.(ProcessRuntimeImpl.java:112)
at org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl.newProcessRuntime(ProcessRuntimeFactoryServiceImpl.java:38)
at org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl.newProcessRuntime(ProcessRuntimeFactoryServiceImpl.java:25)
at org.drools.kiesession.session.ProcessRuntimeFactory.newProcessRuntime(ProcessRuntimeFactory.java:43)
at org.drools.kiesession.session.StatefulKnowledgeSessionImpl.createProcessRuntime(StatefulKnowledgeSessionImpl.java:410)
at org.drools.kiesession.session.StatefulKnowledgeSessionImpl.getProcessRuntime(StatefulKnowledgeSessionImpl.java:421)
at org.jbpm.process.instance.InternalProcessRuntime.asKogitoProcessRuntime(InternalProcessRuntime.java:55)
at org.jbpm.bpmn2.JbpmBpmn2TestCase.createKogitoProcessRuntime(JbpmBpmn2TestCase.java:118)
at org.jbpm.bpmn2.StartEventTest.testMultipleEventBasedStartEventsDifferentPaths(StartEventTest.java:364)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

org.jbpm.bpmn2.StartEventTest.testTimerStartDateISO

Cannot invoke "String.trim()" because "timeExpression" is null

org.jbpm.bpmn2.StartEventTest.testMultipleEventBasedStartEventsSignalDifferentPaths

java.lang.IllegalArgumentException
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:623)
at org.kie.kogito.services.jobs.impl.InMemoryJobService.scheduleProcessJob(InMemoryJobService.java:86)
at org.jbpm.process.instance.ProcessRuntimeImpl.initStartTimers(ProcessRuntimeImpl.java:127)
at org.jbpm.process.instance.ProcessRuntimeImpl.(ProcessRuntimeImpl.java:112)
at org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl.newProcessRuntime(ProcessRuntimeFactoryServiceImpl.java:38)
at org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl.newProcessRuntime(ProcessRuntimeFactoryServiceImpl.java:25)
at org.drools.kiesession.session.ProcessRuntimeFactory.newProcessRuntime(ProcessRuntimeFactory.java:43)
at org.drools.kiesession.session.StatefulKnowledgeSessionImpl.createProcessRuntime(StatefulKnowledgeSessionImpl.java:410)
at org.drools.kiesession.session.StatefulKnowledgeSessionImpl.getProcessRuntime(StatefulKnowledgeSessionImpl.java:421)
at org.jbpm.process.instance.InternalProcessRuntime.asKogitoProcessRuntime(InternalProcessRuntime.java:55)
at org.jbpm.bpmn2.JbpmBpmn2TestCase.createKogitoProcessRuntime(JbpmBpmn2TestCase.java:118)
at org.jbpm.bpmn2.StartEventTest.testMultipleEventBasedStartEventsSignalDifferentPaths(StartEventTest.java:435)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

jbpm/jbpm-flow/src/main/java/org/jbpm/process/instance/ProcessRuntimeImpl.java

jbpm/jbpm-flow/src/main/resources/calendar.properties

pefernan

Great PRogress @Abhitocode I'd suggested you some changes.

jbpm/jbpm-flow/src/main/java/org/jbpm/process/instance/DummyKnowledgeRuntime.java

jbpm/jbpm-flow/src/main/resources/calendar.properties

...cesses/src/main/resources/class-templates/producer/BusinessCalendarProducerJavaTemplate.java

...sses/src/main/resources/class-templates/producer/BusinessCalendarProducerSpringTemplate.java

...esses/src/main/resources/class-templates/producer/ProcessServiceProducerQuarkusTemplate.java

...ses/src/main/resources/class-templates/producer/BusinessCalendarProducerQuarkusTemplate.java

...sses/src/main/resources/class-templates/producer/BusinessCalendarProducerSpringTemplate.java

elguardian · 2024-10-07T13:26:55Z

good work @Abhitocode ... please revisit the formatting (-Dvalidate-formatting)

elguardian

LGTM

kie-ci3 · 2024-10-08T04:59:53Z

PR job #8 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3686 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https:/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3686/8/display/redirect

Test results:

PASSED: 3362
FAILED: 6

Those are the test failures:

org.jbpm.process.instance.LightProcessRuntimeTest.testInstantiation

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[1]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[2]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[3]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[4]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[5]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

pefernan

great work @Abhitocode, I left a few comments here and there but nothing really big. I'd appreciate if you could add some tests in codegen area and maybe in flow to make sure calendars are used.

pefernan · 2024-10-08T07:02:28Z

jbpm/jbpm-flow/src/main/resources/calendar.properties

@@ -0,0 +1,5 @@
+business.end.hour=17


@Abhitocode I think this file should be removed right?

Yes, added calendar.properties based on Jira requirement, will remove it if required to.

It should only be in src/test/resources if required for testing

try (InputStream is = Thread.currentThread().getContextClassLoader().getResourceAsStream("calendar.properties")) {
businessCalendarConfiguration.load(is);
}

we are actually reading the properties from calendar.properties, so can we do this as loading the default properties for business calendar orelse I'l delete it.

jbpm/jbpm-flow/src/test/resources/logback-test.xml

...ses/src/main/resources/class-templates/producer/BusinessCalendarProducerQuarkusTemplate.java

...sses/src/main/resources/class-templates/producer/BusinessCalendarProducerSpringTemplate.java

jbpm/jbpm-flow/pom.xml

jbpm/jbpm-flow/src/main/java/org/jbpm/process/core/timer/BusinessCalendarImpl.java

jbpm/jbpm-flow/src/main/java/org/jbpm/process/instance/DummyKnowledgeRuntime.java

...ogito-codegen-processes/src/test/java/org/kie/kogito/codegen/process/ProcessCodegenTest.java

kie-ci3 · 2024-10-09T06:23:46Z

PR job #11 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3686 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https:/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3686/11/display/redirect

Test results:

PASSED: 3364
FAILED: 6

Those are the test failures:

org.jbpm.process.instance.LightProcessRuntimeTest.testInstantiation

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[1]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[2]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[3]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[4]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[5]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

Abhitocode · 2024-10-10T05:29:16Z

Calendar.properties still exist only for clarification purpose, will remove it once verified with the test to be added.

kie-ci3 · 2024-10-10T08:24:32Z

PR job #12 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3686 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https:/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3686/12/display/redirect

Test results:

PASSED: 3362
FAILED: 9

Those are the test failures:

org.jbpm.process.instance.LightProcessRuntimeTest.testInstantiation

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventInterrupting

expected: 2
but was: 1

org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerDuration

expected: 2
but was: 1

org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2

expected: 2
but was: 1

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[1]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[2]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[3]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[4]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

org.jbpm.bpmn2.ProcessFactoryTest.testBoundaryErrorEvent(String)[5]

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

jbpm/jbpm-flow/src/test/resources/logback-test.xml

kie-ci3 · 2024-10-11T06:30:06Z

PR job #13 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3686 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https:/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3686/13/display/redirect

Test results:

PASSED: 2941
FAILED: 1

Those are the test failures:

org.jbpm.process.instance.LightProcessRuntimeTest.testInstantiation

Cannot invoke "org.kie.kogito.Config.get(java.lang.Class)" because the return value of "org.kie.kogito.Application.config()" is null

gitgabrio · 2024-10-11T07:54:25Z

...ses/src/test/resources/class-templates/producer/BusinessCalendarProducerQuarkusTemplate.java

@@ -0,0 +1,23 @@
+/*


HI @Abhitocode
Why those cloned/empty templates are needed ?

...ogito-codegen-processes/src/test/java/org/kie/kogito/codegen/process/ProcessCodegenTest.java

jbpm/jbpm-flow/src/main/java/org/jbpm/process/core/timer/BusinessCalendarImpl.java

gitgabrio · 2024-10-11T08:43:18Z

jbpm/jbpm-flow/src/main/java/org/jbpm/process/instance/DummyKnowledgeRuntime.java

@@ -72,6 +75,10 @@ class DummyKnowledgeRuntime implements InternalKnowledgeRuntime, KogitoProcessRu
 this.processRuntime = processRuntime;
 this.environment = new EnvironmentImpl();
 // register codegen-based node instances factories
+ BusinessCalendar calendar = processRuntime.getApplication().config().get(ProcessConfig.class).getBusinessCalendar();
+ if (Objects.nonNull(calendar)) {
+ environment.set("jbpm.business.calendar", calendar);


Not strictly related to this PR, but strings used overall codebase as identifiers, should be defined once as public static properties, somewhere, so that whenever they change (as happened for jbpm.business.calendar.properties-> "calendar.properties" ), the code keep working.
Moreover, it is also easier to document them

jbpm/jbpm-flow/src/main/java/org/jbpm/process/core/timer/BusinessCalendarImpl.java

jbpm/jbpm-flow/src/main/java/org/kie/kogito/process/impl/AbstractProcessConfig.java

gitgabrio · 2024-10-11T09:08:14Z

...src/main/java/org/kie/kogito/codegen/process/StaticDependencyInjectionProducerGenerator.java

+ *
+ * @return Map with the generated resources
+ */
+ public Map<String, String> generate(String... templates) {


This method is a duplication of
public Map<String, String> generate()
Please, unify them, e.g.

generate() -> generate(producerTemplates) (you have to adjust list -> varargs)

jbpm/jbpm-flow/src/main/java/org/kie/kogito/process/impl/AbstractProcessConfig.java

martinweiler · 2024-10-11T20:51:06Z

...es/kogito-codegen-processes/src/main/java/org/kie/kogito/codegen/process/ProcessCodegen.java

+ resources.stream().filter(resource -> resource.basePath().toString().equals(BUSINESS_CALENDAR_PATH))
+ .findFirst().ifPresent(resource -> context.addContextAttribute(BUSINESS_CALENDAR_RESOURCE_KEY, true));


resource.basePath() returns the path of the application jar. The check must happen on the contents of this jar instead.

Abhitocode force-pushed the business-calendar branch 2 times, most recently from 7c2e7e5 to c3e5883 Compare October 2, 2024 14:07

pefernan reviewed Oct 2, 2024

View reviewed changes

jbpm/jbpm-flow/src/main/java/org/jbpm/process/instance/ProcessRuntimeImpl.java Outdated Show resolved Hide resolved

pefernan reviewed Oct 2, 2024

View reviewed changes

jbpm/jbpm-flow/src/main/resources/calendar.properties Outdated Show resolved Hide resolved

pefernan reviewed Oct 2, 2024

View reviewed changes

jbpm/jbpm-flow/src/main/resources/calendar.properties Outdated Show resolved Hide resolved

Abhitocode force-pushed the business-calendar branch from c3e5883 to 7bf72d5 Compare October 3, 2024 04:59

pefernan reviewed Oct 4, 2024

View reviewed changes

Abhitocode force-pushed the business-calendar branch 2 times, most recently from 9dd2ce8 to 69dbfd8 Compare October 7, 2024 05:00

elguardian approved these changes Oct 7, 2024

View reviewed changes

Abhitocode force-pushed the business-calendar branch 2 times, most recently from 80e690c to a4cedca Compare October 8, 2024 03:05

pefernan reviewed Oct 8, 2024

View reviewed changes

Abhitocode force-pushed the business-calendar branch 3 times, most recently from 3c01e6d to 217e9bc Compare October 9, 2024 04:32

Abhitocode commented Oct 9, 2024

View reviewed changes

...ogito-codegen-processes/src/test/java/org/kie/kogito/codegen/process/ProcessCodegenTest.java Show resolved Hide resolved

Abhitocode force-pushed the business-calendar branch from 217e9bc to 76547b8 Compare October 10, 2024 05:26

pefernan reviewed Oct 10, 2024

View reviewed changes

jbpm/jbpm-flow/src/test/resources/logback-test.xml Outdated Show resolved Hide resolved

Abhitocode force-pushed the business-calendar branch from 76547b8 to c2fad7b Compare October 11, 2024 04:40

gitgabrio reviewed Oct 11, 2024

View reviewed changes

jbpm/jbpm-flow/src/main/java/org/jbpm/process/core/timer/BusinessCalendarImpl.java Show resolved Hide resolved

gitgabrio reviewed Oct 11, 2024

View reviewed changes

jbpm/jbpm-flow/src/main/java/org/jbpm/process/core/timer/BusinessCalendarImpl.java Outdated Show resolved Hide resolved

gitgabrio reviewed Oct 11, 2024

View reviewed changes

jbpm/jbpm-flow/src/main/java/org/jbpm/process/core/timer/BusinessCalendarImpl.java Outdated Show resolved Hide resolved

gitgabrio reviewed Oct 11, 2024

View reviewed changes

jbpm/jbpm-flow/src/main/java/org/kie/kogito/process/impl/AbstractProcessConfig.java Show resolved Hide resolved

gitgabrio reviewed Oct 11, 2024

View reviewed changes

jbpm/jbpm-flow/src/main/java/org/kie/kogito/process/impl/AbstractProcessConfig.java Show resolved Hide resolved

martinweiler reviewed Oct 11, 2024

View reviewed changes

business-calendar

34e32b7

Abhitocode force-pushed the business-calendar branch from c2fad7b to 34e32b7 Compare October 14, 2024 12:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

business-calendar #3686

business-calendar #3686

Abhitocode commented Oct 1, 2024 •

edited

Loading

kie-ci3 commented Oct 1, 2024

pefernan left a comment

elguardian commented Oct 7, 2024

elguardian left a comment

kie-ci3 commented Oct 8, 2024

pefernan left a comment

pefernan Oct 8, 2024

Abhitocode Oct 8, 2024

martinweiler Oct 8, 2024

Abhitocode Oct 9, 2024

kie-ci3 commented Oct 9, 2024

Abhitocode commented Oct 10, 2024

kie-ci3 commented Oct 10, 2024

kie-ci3 commented Oct 11, 2024

gitgabrio Oct 11, 2024

gitgabrio Oct 11, 2024 •

edited

Loading

gitgabrio Oct 11, 2024 •

edited

Loading

martinweiler Oct 11, 2024

		resources.stream().filter(resource -> resource.basePath().toString().equals(BUSINESS_CALENDAR_PATH))
		.findFirst().ifPresent(resource -> context.addContextAttribute(BUSINESS_CALENDAR_RESOURCE_KEY, true));

business-calendar #3686

Are you sure you want to change the base?

business-calendar #3686

Conversation

Abhitocode commented Oct 1, 2024 • edited Loading

kie-ci3 commented Oct 1, 2024

pefernan left a comment

Choose a reason for hiding this comment

elguardian commented Oct 7, 2024

elguardian left a comment

Choose a reason for hiding this comment

kie-ci3 commented Oct 8, 2024

pefernan left a comment

Choose a reason for hiding this comment

pefernan Oct 8, 2024

Choose a reason for hiding this comment

Abhitocode Oct 8, 2024

Choose a reason for hiding this comment

martinweiler Oct 8, 2024

Choose a reason for hiding this comment

Abhitocode Oct 9, 2024

Choose a reason for hiding this comment

kie-ci3 commented Oct 9, 2024

Abhitocode commented Oct 10, 2024

kie-ci3 commented Oct 10, 2024

kie-ci3 commented Oct 11, 2024

gitgabrio Oct 11, 2024

Choose a reason for hiding this comment

gitgabrio Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

gitgabrio Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

martinweiler Oct 11, 2024

Choose a reason for hiding this comment

Abhitocode commented Oct 1, 2024 •

edited

Loading

gitgabrio Oct 11, 2024 •

edited

Loading

gitgabrio Oct 11, 2024 •

edited

Loading