Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1033: Fix sonataflow-quarkus-devui-extension to adapt it to the Quarkus 3.8 Dev UI #2212

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

paulovmr
Copy link
Member

@paulovmr paulovmr commented Mar 26, 2024

@tiagobento
Copy link
Contributor

@paulovmr Do we really have to wait? I mean, even with those changes, the Dev UI is still compatible with Quarkus 3.2, no?

@paulovmr paulovmr removed the pr: DO NOT MERGE Draft PR, not ready for merging label Mar 26, 2024
@paulovmr
Copy link
Member Author

@tiagobento no, actually I tested with a example running on Quarkus 3.2 and it is working. I edited my restriction comment.

@pefernan
Copy link
Contributor

guys, let me review tomorrow. I don't see much problem but I'd like to give it a test.

Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulovmr great!

my only "but" is about adding the -extension suffix to the artifactId, this isn't matching the new artifacts naming, but if this has been agreed I'm ok..

@paulovmr
Copy link
Member Author

@pefernan I added the route you mentioned to me now. I will take a look at the naming of the other extensions and send a separate PR if necessary to rename it.

@pefernan
Copy link
Contributor

@paulovmr https://docs.google.com/spreadsheets/d/1IN9bH2rCxbV7dcehItqwELfTNaGrXKFT8Ppj6a5Jeb4/edit?usp=drivesdk

@tiagobento tiagobento merged commit 9fc9d1c into apache:main Mar 27, 2024
8 checks passed
paulovmr added a commit to kiegroup/kie-tools that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix sonataflow-quarkus-devui-extension to adapt it to the Quarkus 3.8 Dev UI
3 participants