Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#966: Move the BPMN Quarkus Dev UI package from kogito-apps to kie-tools #2223

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

pefernan
Copy link
Contributor

@pefernan pefernan commented Apr 2, 2024

Closes apache/incubator-kie-issues#966

This PR brings the jbpm-quarkus-devui maven modules from kogito-apps into kie-tools. It includes the following changes:

  • Added the @kie-tools/maven-base package to be used as a parent for all the maven-based packages in kie-tools.
  • Fixed impersonation issues in TaskForm component that was affecting the jbpm-quarkus-devui.

Comment on lines 42 to 43
<quarkus.platform.version>3.2.9.Final</quarkus.platform.version>
<version.org.kie.kogito>999-20240218-SNAPSHOT</version.org.kie.kogito>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hard coding the dependencies version here, I think we should be reusing the values from env. There's other packages doing this.. See https:/apache/incubator-kie-tools/blob/main/packages/dev-deployment-kogito-quarkus-blank-app/install.js

@tiagobento
Copy link
Contributor

tiagobento commented Apr 3, 2024

@pefernan I see there are changes done to runtime-tools-process-dev-ui-webapp and runtime-tools-process-webapp-components that seem unrelated... do you mind adding a comment about them to the PR description?

@tiagobento
Copy link
Contributor

@pefernan I just remembered something. For Maven packages to successfully be installed and not require the -D properties we require during the build, we need to run a Maven plugin called flatten-maven-plugin. The configuration is standard, and I think you can just configure it at the maven-base package, in the <build><plugins>. Every Maven package on kie-tools need to run it so that the published pom.xml doesn't depend on the build properties we pass.

@pefernan
Copy link
Contributor Author

pefernan commented Apr 4, 2024

@pefernan I just remembered something. For Maven packages to successfully be installed and not require the -D properties we require during the build, we need to run a Maven plugin called flatten-maven-plugin. The configuration is standard, and I think you can just configure it at the maven-base package, in the <build><plugins>. Every Maven package on kie-tools need to run it so that the published pom.xml doesn't depend on the build properties we pass.

right!

@tiagobento tiagobento merged commit 41ad791 into apache:main Apr 5, 2024
7 of 8 checks passed
fantonangeli pushed a commit to fantonangeli/kie-tools that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the BPMN Quarkus Dev UI package from kogito-apps to kie-tools
4 participants