Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: temporary disable devservice to sonataflow-greeting-quarkus-example #2511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fantonangeli
Copy link
Contributor

@fantonangeli fantonangeli commented Aug 6, 2024

This PR is related to: #2510

During the work on apache/incubator-kie-issues#1406 we found the error below in sonataflow-greeting-quarkus-example:
com.github.dockerjava.api.exception.NotFoundException: Status 404: {"message":"manifest for apache/incubator-kie-kogito-data-index-ephemeral:main not found: manifest unknown: manifest unknown"}
This PR temporary disables the devservice in sonataflow-greeting-quarkus-example only to fix the error until the dev service issue is solved.

image

@tiagobento
Copy link
Contributor

Sorry I get it that you're disabling it, but why? I followed all the links and I could reach this #2483, but I'm still not sure what is going on. Please improve the description of the PR and make sure to properly link everything that is necessary to understand the reason this PR is being sent.

Copy link
Contributor

@tiagobento tiagobento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my last comment please...

@fantonangeli
Copy link
Contributor Author

See my last comment please...

@tiagobento I updated the description. If you prefer I can create an issue for this.

@tiagobento
Copy link
Contributor

@fantonangeli No need for an issue for quick fixes, but providing enough information for anyone in the community to follow what this PR is about without having to jump between 5 links and go find issues themselves based on the title of the PR. Thanks for updating the description and providing details about the intentions of this PR.

I have a follow-up question based on the information you shared. You're disabling it because it's broken. Where do I go to follow the process on the actual fix that will re-enable this? Thanks.

@wmedvede
Copy link
Contributor

wmedvede commented Aug 6, 2024

@tiagobento I think the origin of the issue is that docker.io/apache/incubator-kie-kogito-data-index-ephemeral:main is not being generated anymore. (and same for the other data-index-xxxx variants and jobs-service-xxxx variants)

Is there any expectation to produce them?

@thiagoelg
Copy link
Member

@wmedvede
Copy link
Contributor

wmedvede commented Aug 6, 2024

Looks like weekly jobs are still running [1], and the latest main image was published two days ago [2].

(Not sure why it doesn't also tag it as main, should it?)

[1] https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/other/job/kogito-images.weekly-deploy/17/ [2] https://hub.docker.com/layers/apache/incubator-kie-kogito-data-index-ephemeral/main-20240804/images/sha256-8b8075db3c370affe5e4528d7b46907953a1a48a0ce70559408db5c5d55e3ce1?context=explore

That's the question. I think that for example, for the dataindex quarkus dev service, to have daily "main" image tag is something welcome. Otherwise, we must make kogito-apps main, point to a timestamped snapshot, that in the build train is produced after the build of kogito-apps main.

And I'd say, that for the other data-index-xxxx and jobs-serivce-xxx image variants too.

@tiagobento
Copy link
Contributor

tiagobento commented Aug 6, 2024

When timestamped SNAPSHOTs are produced, references to other artifacts need to be updated to point to the same timestamp. A timestamped SNAPSHOT of kogito-apps cannot point to the 'main' tag of an image.

@tiagobento
Copy link
Contributor

Also, kogito-images comes after kogito-apps. Why are we referencing kogito-images from kogito-apps?

@ricardozanini
Copy link
Member

When timestamped SNAPSHOTs are produced, references to other artifacts need to be updated to point to the same timestamp. A timestamped SNAPSHOT of kogito-apps cannot point to the 'main' tag of an image.

Wait, main is supposed to follow the main branch, so it's a SNAPSHOT AFAIK. What am I missing here?

@ricardozanini
Copy link
Member

Also, kogito-images comes after kogito-apps. Why are we referencing kogito-images from kogito-apps?

Where are we referencing kogito-images from apps? I remember in the past people using them for testcontainers, but that should be far long removed.

@tiagobento
Copy link
Contributor

@ricardozanini kie-tools depends on upstream repos via timestamped SNAPSHOTs, which should be all frozen to the same timestamp. E.g., kogito-runtimes@2024-08-04-SNAPSHOT should depend on drools@2024-08-04-SNAPSHOT. This is already in place, AFAIK, but from @wmedvede's comment, it looks like even though kie-tools is depending on timestamped SNAPSHOTs, there's a reference to main somewhere.

@tiagobento
Copy link
Contributor

@ricardozanini The main branch of kie-tools does not depend on the main branches of upstream repos.

@ricardozanini
Copy link
Member

@tiagobento I keep forgetting we are on kie-tools. Sure, I understand that. The operator is looking for main tags IIRC.

@tiagobento
Copy link
Contributor

@wmedvede I don't think this PR has anything to do with the sonataflow-operator... does it? I'm confused.

@tiagobento
Copy link
Contributor

And btw the sonataflow-operator package is pointing to timestamped SNAPSHOTs of upstream repos/artifacts...

@wmedvede
Copy link
Contributor

wmedvede commented Aug 7, 2024

@tiagobento
Copy link
Contributor

I understand that @wmedvede, my point is that since we're using a timestamped SNAPSHOT of this dev service module here at kie-tools, we should've seen it trying to download the timestamped SNAPSHOT tag of this image, not main.

@fantonangeli fantonangeli self-assigned this Aug 21, 2024
@tiagobento
Copy link
Contributor

Any updates here please?

@tiagobento tiagobento added the pr: DO NOT MERGE Draft PR, not ready for merging label Sep 5, 2024
@tiagobento
Copy link
Contributor

Any updates @fantonangeli ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sonataflow pr: DO NOT MERGE Draft PR, not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants