Issue #1536: Introduce Short Topic Name #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short Topic Name can be 1) "<tenant>/<namespace>/<topic>" or 2) "<topic>"
|
@merlimat - here the WIP for PIP-11. Can you check if this is what you were thinking? If so, I can continue in this direction. |
sijie
changed the title
sijie
changed the title
|
@merlimat this is ready for reviews |
merlimat
approved these changes
Apr 12, 2018
merlimat
reviewed
Apr 12, 2018
| @@ -143,8 +149,54 @@ public static void main(String[] args) throws Exception { | |||
| // Ignore | |||
| } | |||
|
|
|||
| // Create public tenant | |||
| PropertyAdmin publicProperty = new PropertyAdmin(); | |||
| byte[] publicPropertyDataJson = ObjectMapperFactory.getThreadLocal().writeValueAsBytes(publicProperty); | |||
There was a problem hiding this comment.
I think we would still miss the public/default in standalone mode since it doesn't use this script.
Standalone is creating sample/standalone/ns1 by default when it starts up. We should just change that into public/default
There was a problem hiding this comment.
created a public/default namespace at standalone
merlimat
reviewed
Apr 12, 2018
| new PropertyAdmin(Sets.newHashSet(config.getSuperUserRoles()), Sets.newHashSet(cluster))); | ||
| } | ||
| if (!admin.namespaces().getNamespaces(publicTenant).contains(defaultNamespace)) { | ||
| admin.namespaces().createNamespace(defaultNamespace); |
There was a problem hiding this comment.
For v2, we need to specify the "replication" cluster. I added a convenience method in #1562, though you can just add :
admin.namespaces().setNamespaceReplicationClusters(defaultNamespace, Sets.newHashSet(config.getClusterName());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Topic Name can be 1)
<tenant>/<namespace>/<topic>or 2)<topic>