Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev branch merge ECResourceInfoRestfulAPI #4735 #4745

Closed
wants to merge 6 commits into from
Closed

Dev branch merge ECResourceInfoRestfulAPI #4735 #4745

wants to merge 6 commits into from

Conversation

zhaowenkai111
Copy link
Contributor

@zhaowenkai111 zhaowenkai111 commented Jul 6, 2023

What is the purpose of the change

修改两处语法错误的bug,分别位于 76行和 90 行,还原修改错误的 95 行。
image

Related issues/PRs

Related issues: #4735
Related pr:#4745

Brief change log

  • Define the core abstraction and interfaces of the EngineConn Factory;
  • Define the core abstraction and interfaces of Executor Manager.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

1, 修改 90 行,去掉大括号;
2,修改 91 行,+ticket移到括号里面。
1, omit "}"
2, put "Ticket ID" inside.
@zhaowenkai111
Copy link
Contributor Author

for issue #4735

@zhaowenkai111 zhaowenkai111 changed the base branch from master to release-0.9.4 July 6, 2023 22:11
@zhaowenkai111 zhaowenkai111 changed the base branch from release-0.9.4 to release-1.3.2 July 6, 2023 22:11
@zhaowenkai111
Copy link
Contributor Author

change merge version from master to release apache:release-1.3.2

Copy link
Contributor Author

@zhaowenkai111 zhaowenkai111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for change

@peacewong
Copy link
Contributor

should submit to the master branch

@jackxu2011 jackxu2011 changed the base branch from release-1.3.2 to master July 10, 2023 01:56
@zhaowenkai111 zhaowenkai111 closed this by deleting the head repository Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants