Fix plugin subclassing in Log4j Docgen #120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #117, which misses
loggers > logger
entry.Why is the entry missing?
log4j-core-plugins.xml
contains two entries forLoggerConfig
:<abstractType className="org.apache.logging.log4j.core.config.LoggerConfig">
<plugin name="logger" className="org.apache.logging.log4j.core.config.LoggerConfig">
TypeLookup
encounters the<abstractType
first and consequently discards the<plugin
, hencelogger
doesn't show up in theLoggerConfig
XSDgroup
.How shall we solve the problem?
If an FQCN is a plugin and is also subclassed by other plugins:
DescriptorGenerator
should not generate anAbstractType
, but only aPluginType
.TypeLookup
should promote anAbstractType
to aPluginType
if the associated FQCN is later on found to be a plugin. (This can still be the case even after theDescriptorGenerator
fix mentioned above. That is, the plugin and the subclassed plugin can be provided in different descriptor files.)