Use parameterized logging everywhere

Our code should be an example to users: we should never use string concatenation in log messages. This was performed using OpenRewrite and is related to #1706.
apache · Nov 20, 2023 · 734e548 · 734e548
1 parent 12f4755
commit 734e548
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/message/LocalizedMessage.java b/log4j-api/src/main/java/org/apache/logging/log4j/message/LocalizedMessage.java
@@ -231,7 +231,7 @@ protected ResourceBundle getResourceBundle(
  }
  } catch (final MissingResourceException ex) {
  if (!loop) {
- logger.debug("Unable to locate ResourceBundle " + rbBaseName);
+ logger.debug("Unable to locate ResourceBundle {}", rbBaseName);
  return null;
  }
  }
@@ -247,7 +247,7 @@ protected ResourceBundle getResourceBundle(
  rb = ResourceBundle.getBundle(substr);
  }
  } catch (final MissingResourceException ex) {
- logger.debug("Unable to locate ResourceBundle " + substr);
+ logger.debug("Unable to locate ResourceBundle {}", substr);
  }
  }
  return rb;

diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFormatMessage.java b/log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFormatMessage.java
@@ -100,7 +100,7 @@ protected String formatMessage(final String msgPattern, final Object... args) {
  final MessageFormat temp = new MessageFormat(msgPattern, locale);
  return temp.format(args);
  } catch (final IllegalFormatException ife) {
- LOGGER.error("Unable to format msg: " + msgPattern, ife);
+ LOGGER.error("Unable to format msg: {}", msgPattern, ife);
  return msgPattern;
  }
  }

diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/message/StringFormattedMessage.java b/log4j-api/src/main/java/org/apache/logging/log4j/message/StringFormattedMessage.java
@@ -110,7 +110,7 @@ protected String formatMessage(final String msgPattern, final Object... args) {
  try {
  return String.format(locale, msgPattern, args);
  } catch (final IllegalFormatException ife) {
- LOGGER.error("Unable to format msg: " + msgPattern, ife);
+ LOGGER.error("Unable to format msg: {}", msgPattern, ife);
  return msgPattern;
  }
  }

diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/util/LowLevelLogUtil.java b/log4j-api/src/main/java/org/apache/logging/log4j/util/LowLevelLogUtil.java
@@ -72,7 +72,7 @@ public void error(final String message) {
 
  @Override
  public void error(final Throwable throwable) {
- logger.error(throwable);
+ logger.error("", throwable);
  }
 
  @Override