Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonTemplateLayout does not override the requiresLocation method #1692

Closed
jalynxing opened this issue Aug 11, 2023 · 1 comment
Closed

JsonTemplateLayout does not override the requiresLocation method #1692

jalynxing opened this issue Aug 11, 2023 · 1 comment
Assignees
@vy
Milestone
2.21.0

Comments

@jalynxing
Copy link

JsonTemplateLayout does not implements LocationAware and override requiresLocation, making LoggerConfig::requiresLocation always return false and AbstractLogger::getLocation(fqcn) return null. This results in the location not being passed to its underlying appenders when needed.
Instead, JsonTemplateLayout::requiresLocation should return true when any of its appenders requires a location.
vy added a commit that referenced this issue Aug 16, 2023
@vy
Make JsonTemplateLayout implement LocationAware (#1692)
613b27a
@vy
Copy link
Member

vy commented Aug 16, 2023

Thanks for the report @jalynxing! 😍 Fixed in 613b27a.

@vy vy closed this as completed Aug 16, 2023
@vy vy self-assigned this Aug 16, 2023
@vy vy added this to the 2.20.1 milestone Aug 16, 2023
@ppkarwasz ppkarwasz mentioned this issue Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vy vy

Labels
None yet
Projects
None yet
Milestone
2.21.0
Development

No branches or pull requests
2 participants
@vy @jalynxing