-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DI system with DSL for configuring bindings #2147
Comments
jvz
added a commit
to jvz/logging-log4j2
that referenced
this issue
Jan 2, 2024
- `DI.FactoryBuilder` and related builder classes for configuring a `ConfigurableInstanceFactory`. - Repeatable `@TestBinding` test annotation for specifying simple bindings in tests. - `@LegacyLoggerContextSource` test annotation for specifying v1-style configuration files. - Test extension updates to improve compatibility of different annotations. Related to apache#2147 Signed-off-by: Matt Sicker <[email protected]>
jvz
added a commit
to jvz/logging-log4j2
that referenced
this issue
Jan 2, 2024
Completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I first came up with this idea while working out how to remove the need for loading classes from an unknown
ClassLoader
that I needed a couple updates to the DI system:@TestBinding
repeatable annotation for making it easy to register custom test bindings for a test. As it stands now, the only way test bindings could be specified was via methods on the test class to register said class as a bundle. This approach does not work with tests that use constructor injection for JUnit extension-provided arguments, thus requiring a different mechanism for test bindings. This should clean up the various test extension code inlog4j-core-test
.DI
to make it simpler to register bindings that are registered either before or after the list ofConfigurableInstanceFactoryPostProcessor
services are invoked.Since the original branch for that code spiraled into a tangent branch, I'm breaking up the changes there into relevant pieces.
The text was updated successfully, but these errors were encountered: