Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ZSTD Compression #1514

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Support for ZSTD Compression #1514

merged 4 commits into from
Oct 11, 2023

Conversation

anuragagarwal561994
Copy link
Contributor

This PR adds support for zstd compression using CommonsCompressAction.

Closes #1508

@anuragagarwal561994
Copy link
Contributor Author

@vy you can check the MR here, just a suggestion commons-compress provides CompressorStreamFactory which provides constants for all the compressions available. Do you think instead of writing and changing comments everywhere we can use this constants instead and remove comments to be more verbose.

@vy vy mentioned this pull request Jun 18, 2023
@ppkarwasz ppkarwasz added this to the 2.20.1 milestone Jul 13, 2023
@ppkarwasz ppkarwasz removed this from the 2.20.1 milestone Aug 29, 2023
vy added a commit that referenced this pull request Oct 11, 2023
@vy vy merged commit d6563e3 into apache:2.x Oct 11, 2023
@vy vy self-assigned this Oct 11, 2023
@vy vy added the enhancement Additions or updates to features label Oct 11, 2023
@vy vy added this to the 2.21.0 milestone Oct 11, 2023
@vy
Copy link
Member

vy commented Oct 11, 2023

@anuragagarwal561994, I have merged this. Thanks for the contribution. This will be available in the 2.21.0 release that should come out sometime this week.

@anuragagarwal561994
Copy link
Contributor Author

Thanks @vy can finally remove a tech debt from our projects :D

LuciferYang added a commit to apache/spark that referenced this pull request Oct 23, 2023
### What changes were proposed in this pull request?
This pr aims upgrade log4j from 2.20.0 to 2.21.0.

### Why are the changes needed?
Support for the zstd compression algorithm has been added in the new version: apache/logging-log4j2#1508 | apache/logging-log4j2#1514
Meanwhile, the new version starts to use Java 11 for building, and the runtime version is still compatible with Java 8: apache/logging-log4j2#1369
The new version also brings some bug fixes, such as:
- Fixed logging of java.sql.Date objects by appending it before Log4J tries to call java.util.Date.toInstant() on it: apache/logging-log4j2#1366
- Fixed concurrent date-time formatting issue in PatternLayout: apache/logging-log4j2#1485
- Fixed buffer size in Log4jFixedFormatter date time formatter: apache/logging-log4j2#1418
- Fixed the propagation of synchronous action failures in RollingFileManager and FileRenameAction: apache/logging-log4j2#1445 | apache/logging-log4j2#1549
- Fixed RollingFileManager to propagate failed synchronous actions correctly: apache/logging-log4j2#1445
and more.

The complete release note is as follows:
- https:/apache/logging-log4j2/releases/tag/rel%2F2.21.0

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #43478 from LuciferYang/SPARK-45625.

Authored-by: yangjie01 <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additions or updates to features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zstd compression support
3 participants