-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade 2.x
compiler baseline to Java 17
#2021
Conversation
JEP-335 has deprecated Nashorn in Java 11, and JEP-372 removed it in Java 15.
This is necessary for Java 12+ compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...e-test/src/test/java/org/apache/logging/log4j/core/pattern/DatePatternConverterTestBase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks so much for the review, much appreciated! 🙏 I have reverted test dependency upgrades. I will merge the changes sometime today. |
Warning!
revision
needs to be adjusted prior to merge.