-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MCOMPILER-525] Incorrect detection of dependency change #172
Conversation
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
Outdated
Show resolved
Hide resolved
@jorsol thanks for your PR. is your issue fixed if you try this PR https:/apache/maven-compiler-plugin/pull/172/files#r1090053416? |
b1c7189
to
0dac7fd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
4d83128
to
9e1a2bd
Compare
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
Outdated
Show resolved
Hide resolved
e9052ad
to
005ae0f
Compare
@slawekjaranowski @olamy I think I have addressed all the comments, even I end up basically fixing the issue MCOMPILER-381 too. There are a lot of other improvements that can be made, refactor legacy code, and more, but for now I don't want to keep touching and touching this (every time I look I end up making some small refactor), this should be a good improvement so far, as of performance concerns this should be at least equally performant than the previous code. |
40c3cf2
to
f6db9fb
Compare
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
Outdated
Show resolved
Hide resolved
@jorsol I have a hard time understanding the exact change that fixes the problem. Would it be possible to have a first commit that refactors the code using the nio api and other improvements, and another commit with the actual fix for the problem ? Note that we could also embeds the trimmed down version of the |
a6f005a
to
9f341ff
Compare
@gnodet sure, the fix for this issue is trivial, so I undo all the refactoring and only provide the actual fix. |
…ency change Signed-off-by: Jorge Solórzano <[email protected]>
9f341ff
to
e6c9bc4
Compare
Thanks @gnodet , I will open the refactor PR for MCOMPILER-381 that was previously done here ASAP and then later I could check if I could use the |
This fix a bug with the incremental compilation related to the incorrect detection of the project classes as a dependency.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MCOMPILER-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.