[MSHARED-1296] vuln-fix: Temporary File Information Disclosure (#62)

This fixes temporary file information disclosure vulnerability due to the use
of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by
using the `Files.createTempFile()` method which sets the correct posix permissions.

Weakness: CWE-377: Insecure Temporary File
Severity: Medium
CVSSS: 5.5
Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation)

Reported-by: Jonathan Leitschuh <[email protected]>


Bug-tracker: JLLeitschuh/security-research#18

Co-authored-by: Moderne <[email protected]>

src/main/java/org/apache/maven/shared/verifier/ForkedLauncher.java

@@ -23,6 +23,7 @@
 import java.io.FileWriter;
 import java.io.IOException;
 import java.io.Writer;
+import java.nio.file.Files;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
@@ -169,7 +170,7 @@ public String getMavenVersion()
  File logFile;
  try
  {
- logFile = File.createTempFile( "maven", "log" );
+ logFile = Files.createTempFile( "maven", "log" ).toFile();
  }
  catch ( IOException e )
  {