Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8196] Make exception messages match Maven 3 again #1628

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

oehme
Copy link
Contributor

@oehme oehme commented Aug 6, 2024

The boxing of MojoException into a MojoExecutionException brought two issues:

  1. It added another layer to the stacktrace, making it a bit less readable for users and breaking test expectations for Maven extension authors (the latter was my main motivation for this change)
  2. It lost the longMessage, which meant that this message was no longer shown at the end of the build.

This change fixes both problems by passing through the original MojoException and treating this new exception type directly in DefaultExceptionHandler and MojoExecutor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.


https://issues.apache.org/jira/browse/MNG-8196

@cstamas cstamas requested a review from gnodet August 9, 2024 09:50
@cstamas cstamas changed the title Make exception messages match Maven 3 again [MNG-8196] Make exception messages match Maven 3 again Aug 9, 2024
@cstamas cstamas added this to the 4.0.0-beta-4 milestone Aug 9, 2024
The boxing of `MojoException` into a `MojoExecutionException` brought two issues:

1. It added another layer to the stacktrace, making it a bit less readable for users and breaking test expectations for Maven extension authors (this was my main motivation for this change)
2. It lost the `longMessage`, which meant that this message was no longer shown at the end of the build.

This change fixes both problems by passing through the original `MojoException` and treating this new exception type directly in `DefaultExceptionHandler` and `MojoExecutor`
@gnodet gnodet merged commit e417e45 into apache:master Aug 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants