This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
DTypes for Concat, UpSampling, Reshape, BlockGrad, SwapAxis and ElementWiseSum #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
|
These extensions are fairly similar. Just add consistency tests and it should be good to merge |
vchuravy
force-pushed
the
vc/dtypes
branch
2 times, most recently
from
9a90c84
to
c3c87dd
Compare
vchuravy
changed the title
|
All these operators are fairly easily extended to multiple DTypes. |
vchuravy
changed the title
|
LGTM |
|
@tqchen Should I rebase or can you merge? |
|
@vchuravy Could you rebase and I'll merge? |
|
rebased. |
|
@vchuravy How about to squash them to a single commit and I'll merge it after the Travis test. |
|
Each of the commits is independent for each operator, so I prefer keeping them atomic |
|
@vchuravy Fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends concat and upsampling to work with all dtypes.
cc: @piiswrong
Todo: