Use img_mgmt_find_best_area_id to select upload slot instead of FLASH_AREA_ID #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The img_mgmt_find_best_area_id is supposed to figure out the best, which also means possible, partition for software update. Unfortunately in the code in many places the direct reference the to FLASH_AREA_ID(image_1) is used, which may cause image_1 being overwritten, even if other partition would be selected as the "best". Signed-off-by: Dominik Ermel <[email protected]>
Within mcumgr Zephyr port, the img_mgmt_find_best_area_id is used to get information on the update flash ID, yet the call to the flash_img_init selects such flash ID via value hardcoded during compilation. This may lead to situation where the mcumgr library and flash_img_init may select different partition for update. This commit replaces call to flash_img_init with flash_img_init_id, which takes flash area ID as a parameter, and uses img_mgmt_find_best_area_id to get the ID. This approach is better as img_mgmt_find_best_area_id, while searching for empty image, will also check its boot status (pending, test, etc). Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
added a commit
to de-nordic/zephyr
that referenced
this pull request
Feb 11, 2021
This is test commit for mcumgr change: apache/mynewt-mcumgr#110 Signed-off-by: Dominik Ermel <[email protected]>
|
@nvlsianpu , @utzig Please check. |
utzig
approved these changes
Feb 11, 2021
nvlsianpu
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mcumgr should relay on single decision point for upload flash area selection; instead the
img_mgmt_find_best_area_idand FLASH_AREA_ID macros were used for similar purpose through the code, even thoughimg_mgmt_find_best_area_idis more restrictive and may not agree withFLASH_AREA_ID.