OPENNLP-1618 - AbstractDL does not release Ort Resources

apache · Oct 10, 2024 · e15a618 · e15a618
1 parent eb777d2
commit e15a618
Show file tree

Hide file tree

Showing 4 changed files with 228 additions and 197 deletions.
diff --git a/opennlp-dl/src/main/java/opennlp/dl/AbstractDL.java b/opennlp-dl/src/main/java/opennlp/dl/AbstractDL.java
@@ -34,7 +34,7 @@
 /**
  * Base class for OpenNLP deep-learning classes using ONNX Runtime.
  */
-public abstract class AbstractDL {
+public abstract class AbstractDL implements AutoCloseable {
 
  public static final String INPUT_IDS = "input_ids";
  public static final String ATTENTION_MASK = "attention_mask";
@@ -50,7 +50,6 @@ public abstract class AbstractDL {
  *
  * @param vocabFile The vocabulary file.
  * @return A map of vocabulary words to integer IDs.
- *
  * @throws IOException Thrown if the vocabulary file cannot be opened or read.
  */
  public Map<String, Integer> loadVocab(final File vocabFile) throws IOException {
@@ -66,4 +65,19 @@ public Map<String, Integer> loadVocab(final File vocabFile) throws IOException {
  return vocab;
  }
 
+ /**
+ * Closes this resource, relinquishing any underlying resources.
+ *
+ * @throws Exception If it failed to close.
+ */
+ @Override
+ public void close() throws Exception {
+ if (session != null) {
+ session.close();
+ }
+ if (env != null) {
+ env.close();
+ }
+ }
+
 }