Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change XWPFDocument#getNextPicNameNumber slot selection implementation #194

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

MariusVolkhart
Copy link
Contributor

Previously, the implementation would result in a slot that was greater than the total count of pictures in the document and was available. For example, a document that had [1.png, 3.jpeg] would get a slot of 4, regardless of the format.

The new implementation gives the first slot that is available for the specific format. That same document of [1.png, 3.jpeg] will now issue slot 2 for a PNG and slot 1 for a JPEG.

Previously, the implementation would result in a slot that was greater than the total count of pictures in the document and was available. For example, a document that had [1.png, 3.jpeg] would get a slot of 4, regardless of the format.

The new implementation gives the first slot that is available for the specific format. That same document of [1.png, 3.jpeg] will now issue slot 2 for a PNG and slot 1 for a JPEG.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant