Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine int cast long #348

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

XenoAmess
Copy link

No description provided.

@pjfanning
Copy link
Contributor

applied some of these changes - rebase and see if you want to get the rest merged

@@ -185,7 +185,7 @@ void test62872() throws Exception {
cell = row.createCell(j - 1);

//make some noise
cell.setCellValue(new Date(i * TEN_MINUTES + (j * TEN_MINUTES) / COLUMN_COUNT));
cell.setCellValue(new Date((long) i * TEN_MINUTES + (j * TEN_MINUTES) / COLUMN_COUNT));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is test code - not worth changing

@@ -29,7 +29,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
public final class Notes extends SheetContainer
{
private byte[] _header;
private static long _type = 1008l;
private static long _type = 1008L;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change the l to an L?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants