[ISSUE #884]fix goroutine leak (#885)

* [ISSUE #884]fix goroutine leak * mock UnregisterConsumer
apache · Aug 6, 2022 · 43edd17 · 43edd17
1 parent 3ccfbff
commit 43edd17
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/consumer/push_consumer.go b/consumer/push_consumer.go
@@ -225,7 +225,7 @@ func (pc *pushConsumer) Start() error {
  for k := range pc.subscribedTopic {
  _, exist := pc.topicSubscribeInfoTable.Load(k)
  if !exist {
- pc.client.Shutdown()
+ pc.Shutdown()
  return fmt.Errorf("the topic=%s route info not found, it may not exist", k)
  }
  }

diff --git a/consumer/push_consumer_test.go b/consumer/push_consumer_test.go
@@ -19,9 +19,10 @@ package consumer
 
 import (
  "context"
- "github.com/apache/rocketmq-client-go/v2/rlog"
  "testing"
 
+ "github.com/apache/rocketmq-client-go/v2/rlog"
+
  "github.com/apache/rocketmq-client-go/v2/internal"
  "github.com/apache/rocketmq-client-go/v2/primitive"
  "github.com/golang/mock/gomock"
@@ -80,6 +81,7 @@ func TestStart(t *testing.T) {
 
  Convey("test topic route info not found", func() {
  client.EXPECT().Shutdown().Return()
+ client.EXPECT().UnregisterConsumer(gomock.Any()).Return()
  err = c.Start()
  So(err.Error(), ShouldContainSubstring, "route info not found")
  })