feat(nameserver): correct impl of UpdateTopicRouteInfo (#406)

default Topic is extra for UpdateTopicRouteInfo, and will cause incorrect config to retry topic. Closes #404
apache · Feb 12, 2020 · 683c9ac · 683c9ac
1 parent 4f9013e
commit 683c9ac
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/internal/route.go b/internal/route.go
@@ -118,13 +118,10 @@ func (s *namesrvs) UpdateTopicRouteInfo(topic string) (*TopicRouteData, bool) {
 
  routeData, err := s.queryTopicRouteInfoFromServer(topic)
  if err != nil {
- routeData, err = s.queryTopicRouteInfoFromServer(defaultTopic)
- if err != nil {
- rlog.Warning("query topic route from server error", map[string]interface{}{
- rlog.LogKeyUnderlayError: err,
- })
- return nil, false
- }
+ rlog.Warning("query topic route from server error", map[string]interface{}{
+ rlog.LogKeyUnderlayError: err,
+ })
+ return nil, false
  }
 
  if routeData == nil {