Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Native] remove extra json tag #278

Closed
xujianhai666 opened this issue Nov 3, 2019 · 1 comment
Closed

[Native] remove extra json tag #278

xujianhai666 opened this issue Nov 3, 2019 · 1 comment
Labels
enhancement New feature or request
Milestone
Native-2.0.0-alpha3

Comments

@xujianhai666
Copy link
Member

FEATURE REQUEST

  1. Please describe the feature you are requesting.
    In request.go, json tag is extra. remove better.

  2. Provide any additional detail on your proposed use case for this feature.

  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

  4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:
xujianhai666 added a commit to xujianhai666/rocketmq-client-go that referenced this issue Nov 4, 2019
@xujianhai666
feat(protocol): remove extra json tag
0656a85 
- delete json tag in internal/request.go

Closes apache#278
@xujianhai666 xujianhai666 mentioned this issue Nov 4, 2019
Merged
@wenfengwang wenfengwang added the enhancement New feature or request label Nov 4, 2019
@wenfengwang wenfengwang added this to the Native-2.0.0-alpha3 milestone Nov 4, 2019
xujianhai666 added a commit to xujianhai666/rocketmq-client-go that referenced this issue Nov 4, 2019
@xujianhai666
feat(protocol): remove extra json tag
46c67c4 
- delete json tag in internal/request.go

Closes apache#278
@wenfengwang
Copy link
Member

fixed at: #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Native-2.0.0-alpha3
Development

No branches or pull requests
2 participants
@wenfengwang @xujianhai666