Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Native] [Bug] rmqClient close #293

Closed
xujianhai666 opened this issue Nov 8, 2019 · 0 comments
Closed

[Native] [Bug] rmqClient close #293

xujianhai666 opened this issue Nov 8, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@xujianhai666
Copy link
Member

BUG REPORT
Please add the branch name [Native]/[Master] at the header of the Isssue title.

  1. Please describe the issue you observed:

    • What did you do (The steps to reproduce)?
      rmqClient use close bool to represent the current status, but there are many goroutines run for rmqClient, which means race condition, sometimes close will miss for some goroutine.
      we observe sometimes partitions are blocked without any consuming, we doubt close is the murderer.

    • What did you expect to see?
      close should be chan for really close.

    • What did you see instead?

  2. Please tell us about your environment:

    • What is your OS?

    • What is your client version?

    • What is your RocketMQ version?

  3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

@ShannonDing ShannonDing added the bug Something isn't working label Nov 8, 2019
@ShannonDing ShannonDing added this to the Native-2.0.0-alpha3 milestone Nov 8, 2019
wenfengwang added a commit that referenced this issue Nov 20, 2019
* optimize shutdown rmqClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants