Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #288] Add SetLogger method #290

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Conversation

wenfengwang
Copy link
Member

  • add SetLogger method for the user to specify a customized logger
  • add Code Coverage label in README.md

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #290 into native will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           native     #290   +/-   ##
=======================================
  Coverage   26.15%   26.15%           
=======================================
  Files          46       46           
  Lines        5058     5058           
=======================================
  Hits         1323     1323           
  Misses       3558     3558           
  Partials      177      177
Impacted Files Coverage Δ
internal/route.go 4.76% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25a2aa...af7bef4. Read the comment docs.

@wenfengwang wenfengwang merged commit 4364ebd into apache:native Nov 7, 2019
@wenfengwang wenfengwang changed the title Add SetLogger method [ISSUE #288] Add SetLogger method Nov 7, 2019
@ShannonDing ShannonDing added this to the Native-2.0.0-alpha3 milestone Nov 8, 2019
@ShannonDing ShannonDing added the enhancement New feature or request label Nov 8, 2019
@wenfengwang wenfengwang deleted the native branch November 28, 2019 08:35
@wenfengwang wenfengwang restored the native branch November 28, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants