Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #354] feat: Support PanicHandler #355

Merged
merged 4 commits into from
Jan 7, 2020

Conversation

xujianhai666
Copy link
Member

Closes #354

@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #355 into native will decrease coverage by <.01%.
The diff coverage is 34.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           native     #355      +/-   ##
==========================================
- Coverage   25.38%   25.37%   -0.01%     
==========================================
  Files          47       47              
  Lines        5449     5470      +21     
==========================================
+ Hits         1383     1388       +5     
- Misses       3876     3892      +16     
  Partials      190      190
Impacted Files Coverage Δ
internal/client.go 0.24% <0%> (ø) ⬆️
internal/trace.go 30.03% <0%> (-0.99%) ⬇️
primitive/base.go 20% <0%> (-5%) ⬇️
producer/producer.go 29.84% <0%> (-0.19%) ⬇️
consumer/statistics.go 63.66% <100%> (ø) ⬆️
consumer/push_consumer.go 13.42% <42.85%> (+0.13%) ⬆️
internal/remote/remote_client.go 48.69% <87.5%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33798bc...bd57dd5. Read the comment docs.

@wenfengwang wenfengwang added the enhancement New feature or request label Jan 3, 2020
@wenfengwang wenfengwang added this to the 2.0.0-RC1 milestone Jan 3, 2020
@wenfengwang
Copy link
Member

The panic handler not needed in the client, because the logic of it should be controlled, any unexpected panic(error) should be fixed. if one has trouble with panic, there should add a panic handler by themself

@wenfengwang wenfengwang removed this from the 2.0.0-RC1 milestone Jan 6, 2020
@wenfengwang wenfengwang added wontfix This will not be worked on enhancement New feature or request and removed enhancement New feature or request wontfix This will not be worked on labels Jan 6, 2020
@wenfengwang wenfengwang added this to the 2.0.0-RC1 milestone Jan 6, 2020
@xujianhai666 xujianhai666 force-pushed the feat-panichandler branch 2 times, most recently from d030a37 to 1190fc7 Compare January 7, 2020 05:25
@wenfengwang wenfengwang merged commit 7308bc9 into apache:native Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants