Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #415] feat(producer): auto create topic for producer #416

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

xujianhai666
Copy link
Member

Closes #415

@ShannonDing ShannonDing added the enhancement New feature or request label Feb 18, 2020
@ShannonDing
Copy link
Member

CI error, go fmt for internal/route.go

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI error.

@codecov-io
Copy link

Codecov Report

Merging #416 into native will decrease coverage by 0.21%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           native     #416      +/-   ##
==========================================
- Coverage    24.9%   24.69%   -0.22%     
==========================================
  Files          48       48              
  Lines        5480     5535      +55     
==========================================
+ Hits         1365     1367       +2     
- Misses       3928     3980      +52     
- Partials      187      188       +1
Impacted Files Coverage Δ
internal/namesrv.go 66% <ø> (ø) ⬆️
internal/mock_namesrv.go 0% <0%> (ø) ⬆️
primitive/errors.go 0% <0%> (ø) ⬆️
internal/route.go 9.48% <0%> (-0.4%) ⬇️
internal/client.go 0.23% <0%> (ø) ⬆️
producer/producer.go 29.3% <0%> (-0.55%) ⬇️
producer/option.go 38.29% <45.45%> (-2.73%) ⬇️
consumer/push_consumer.go 12.41% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc707f...5d9f6be. Read the comment docs.

@xujianhai666 xujianhai666 changed the title feat(producer): auto create topic for producer [ISSUE #415] feat(producer): auto create topic for producer Feb 23, 2020
@ShannonDing ShannonDing merged commit 1ade23a into apache:native Feb 24, 2020
@ShannonDing ShannonDing added this to the 2.0.0 milestone Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants