Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #813] Fix bug when get mqadmin consumerStatus can't get consume status. #812

Conversation

lifepuzzlefun
Copy link
Contributor

@lifepuzzlefun lifepuzzlefun commented Apr 18, 2022

fix #813

mqadmin consumerStatus command should get consumeRT related metrics. but current code return all 0.0

Brief changelog

parameter pass to method wrong.

Verifying this change

mqadmin consumerStatus now show value not 0.0

@guyinyou
Copy link
Contributor

It is recommended to modify this part:
consumer/statistics.go:113
consumer/statistics.go:117
consumer/statistics.go:121
consumer/statistics.go:129
consumer/statistics.go:133

like:
getPullRT(group, topic string) -> getPullRT(toipc, group string)

Because then it can be aligned with the Java version
image

@ShannonDing ShannonDing changed the title Fix bug when get mqadmin consumerStatus can't get consume status. [ISSUE #813] Fix bug when get mqadmin consumerStatus can't get consume status. Jul 21, 2022
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing added this to the 2.1.1 milestone Jul 21, 2022
@ShannonDing ShannonDing added the bug Something isn't working label Jul 21, 2022
@ShannonDing ShannonDing merged commit 509d461 into apache:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetConsumerRunningInfo can't get consumeStatus correctly.
3 participants