Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #894](feat): add filter hooks in consumer. #891

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

superhx
Copy link
Contributor

@superhx superhx commented Aug 17, 2022

Add filter hooks to consumer

Developer can use filter hooks to filter pulled messages before message processing.

close #894

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #891 (ed62cf0) into master (ae76839) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
- Coverage   23.81%   23.77%   -0.04%     
==========================================
  Files          52       52              
  Lines        7105     7116      +11     
==========================================
  Hits         1692     1692              
- Misses       5187     5198      +11     
  Partials      226      226              
Impacted Files Coverage Δ
consumer/consumer.go 17.61% <0.00%> (-0.24%) ⬇️
consumer/option.go 20.33% <0.00%> (-0.54%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ShannonDing ShannonDing added the discuss Something undering disscussing label Aug 17, 2022
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what scenario this feature is used in. First of all, I think we can use tags to filter messages directly. If some messages do not need to be processed by the business, we can also directly return success when consuming.

@superhx
Copy link
Contributor Author

superhx commented Aug 17, 2022

scenario this featu

  1. Java SDK has the FilterMessageHook
  2. Don't want send success consumed trace when message is filtered。

@lizhanhui
Copy link

It makes sense to have a business tier filter mechanism.

@lizhanhui
Copy link

@superhx One more thing, you may request this feature here too, where the next major version is being built.

@superhx superhx requested review from ShannonDing and removed request for maixiaohai, zongtanghu and francisoliverlee August 18, 2022 03:23
@ShannonDing ShannonDing changed the title (feat): add filter hooks [ISSUE #894](feat): add filter hooks in consumer. Aug 18, 2022
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 19, 2022
@ShannonDing ShannonDing merged commit fedf106 into apache:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Something undering disscussing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message filter extension hook
4 participants