Replacing github.com/satori/go.uuid with github.com/google/uuid #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
=======================================
Coverage 23.33% 23.33%
=======================================
Files 52 52
Lines 7265 7265
=======================================
Hits 1695 1695
Misses 5338 5338
Partials 232 232
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Can we merge this? |
it will be merge soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library github.com/satori/go.uuid didn't release new version in 4 years and there is CVE-2021-3538 vulnerability.
and github.com/satori/go.uuid v1.2.1, is conflict with v1.2.0 when we use dubbo-go who use v1.2.1, so we cant use both in a project.
fix #919