Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Reduce unnecessary switches #8822

Open
1 task done
LetLetMe opened this issue Oct 15, 2024 · 0 comments
Open
1 task done

[Enhancement] Reduce unnecessary switches #8822

LetLetMe opened this issue Oct 15, 2024 · 0 comments

Comments

@LetLetMe
Copy link
Contributor

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Rocksdb cq升级过程中有一些判断是否需要转换元数据和offset的开关,之前处于保护的逻辑添加了这些开关,但是似乎有点太多了。现在把他们都去掉,统一使用storeType这个开关,也就是当storeType=defaultRocksdb时,会统一校验元数据和offset是否需要转换

In the process of upgrading RocksDB CQ, there were several switches added to determine whether metadata and offsets needed conversion. These switches were initially added as a protective measure, but it seems there are too many of them now. We are now removing all of them and using a single switch, storeType. When storeType=defaultRocksdb, it will uniformly check whether metadata and offsets need conversion.

Motivation

nothing

Describe the Solution You'd Like

nothing

Describe Alternatives You've Considered

nothing

Additional Context

nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant