Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8777] enhance error log when when can't connect to namesrv addrs #8778

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

juhuan
Copy link

@juhuan juhuan commented Sep 30, 2024

Which Issue(s) This PR Fixes

Fixes #8777

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.38%. Comparing base (551c8c3) to head (abba5c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #8778   +/-   ##
==========================================
  Coverage      47.37%   47.38%           
+ Complexity     11558    11557    -1     
==========================================
  Files           1282     1282           
  Lines          89864    89864           
  Branches       11563    11563           
==========================================
+ Hits           42575    42579    +4     
+ Misses         42040    42032    -8     
- Partials        5249     5253    +4     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize error messages when Namesrv address configuration is incorrect
5 participants